Explore performance optimizations #3186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +74,7 @@ public class ClassTypeInformation<S> extends TypeDiscoverer<S> { | |||
| */ | |||
| @Deprecated | |||
| public static <S> ClassTypeInformation<S> from(Class<S> type) { | |||
| return from(ResolvableType.forClass(type)); | |||
| return from(resolvableTypeCache.get(type)); | |||
There was a problem hiding this comment.
👍 - I just realised the ResolvableType internal cache does not cover this part.
Try to be as close to the previous implementation but still benefit from the non locking read operation.
christophstrobl
force-pushed
the
issue/3185
branch
from
0d434ff to
3103fa9
Compare
christophstrobl
added a commit
that referenced
this pull request
Oct 31, 2024
Use double checked locking to be as close to the previous implementation but still benefit from the fast read operation. Original Pull Request: #3186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3185